Removed ~str pattern #12756
Closed
Removed ~str pattern #12756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we have a longer commit message? e.g. explaining a bit about why this is disappearing. |
|
Updated. |
|
The commit message isn't quite accurate. To the best of my knowledge we will never get matching on This is the commit message that I was thinking of: cc @pcwalton |
|
I was talking to eddyb over the IRC and that's the impression I got. Of course, I might have just misunderstood him. I'll update the commit message once we get confirmation from @pcwalton |
The `~str` type is not long for this world as it will be superseded by the soon-to-come DST changes for the language. The new type will be `~Str`, and matching over the allocation will no longer be supported. Matching on `&str` will continue to work, in both a pre and post DST world.
|
@alexcrichton Changed commit message and rebased! |
bors
added a commit
that referenced
this pull request
Mar 13, 2014
match-drop-strs-issue-4541.rs deleted as it's the same with issue-4541.rs
Kroisse
added a commit
to Kroisse/rust-mustache
that referenced
this pull request
Mar 17, 2014
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jun 27, 2024
…xendoo Avoid emitting `assigning_clones` when cloned data borrows from the place to clone into Fixes rust-lang#12444 Fixes rust-lang#12460 Fixes rust-lang#12749 Fixes rust-lang#12757 Fixes rust-lang#12929 I think the documentation for the function should describe what- and how this is fixing the issues well. It avoids emitting a warning when the data being cloned borrows from the place to clone into, which is information that we can get from `PossibleBorrowerMap`. Unfortunately, it is a tiny bit tedious to match on the MIR like that and I'm not sure if this is possibly relying a bit too much on the exact MIR lowering for assignments. Things left to do: - [x] Handle place projections (or verify that they work as expected) - [x] Handle non-`Drop` types changelog: [`assigning_clones`]: avoid warning when the suggestion would lead to a borrow-check error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
match-drop-strs-issue-4541.rs deleted as it's the same with issue-4541.rs